Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16779 )
Change subject: KUDU-2612 keep-alive txn heartbeating for C++ client ...................................................................... Patch Set 3: (2 comments) Thank you for the review! http://gerrit.cloudera.org:8080/#/c/16779/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16779/3//COMMIT_MSG@14 PS3, Line 14: goes : out of scope. In contrast, if the transaction handle is created by : KuduTransaction::Deserialize(), the keepalive messages are or aren't > Can it happen that the original txn handle doesn't go out of scope and anot Yes, of course it's possible to have two actors sending keepalive messages for the same transaction. No, of course it's not a problem at all to have such a situation -- it doesn't hurt to have few actors sending those. It's enough to have just one actor sending keepalive messages for an ongoing transaction, and it's preferable to keep the number as low as possible to put less load on the cluster as possible. http://gerrit.cloudera.org:8080/#/c/16779/3/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/16779/3/src/kudu/client/client.h@485 PS3, Line 485: ring topology > Just curious, do you know any applications (that integrate with Kudu or not No, at this point I don't know about such applications. -- To view, visit http://gerrit.cloudera.org:8080/16779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0283d8e16908f641388f7a30b513a672df27a186 Gerrit-Change-Number: 16779 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 08 Dec 2020 17:43:49 +0000 Gerrit-HasComments: Yes
