Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16770 )

Change subject: [CLI] introduce connection negotiation timeout
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16770/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16770/2//COMMIT_MSG@14
PS2, Line 14: connection_negotiation_timeout_ms
To shorten the command line arguments could it be `negotiation_timeout_ms`? Or 
is there another type of negotiation?


http://gerrit.cloudera.org:8080/#/c/16770/2/src/kudu/tools/tool_action_common.cc
File src/kudu/tools/tool_action_common.cc:

http://gerrit.cloudera.org:8080/#/c/16770/2/src/kudu/tools/tool_action_common.cc@144
PS2, Line 144: DEFINE_int64(connection_negotiation_timeout_ms, 8000,
Any reason this value is different than the default rpc_negotiation_timeout_ms 
defined in server_base.cc?



--
To view, visit http://gerrit.cloudera.org:8080/16770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5627517fd1da4f4d7472f1f0af810d741efe3390
Gerrit-Change-Number: 16770
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Comment-Date: Mon, 30 Nov 2020 02:47:29 +0000
Gerrit-HasComments: Yes

Reply via email to