Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16770 )
Change subject: [CLI] introduce connection negotiation timeout ...................................................................... Patch Set 2: -Verified (2 comments) http://gerrit.cloudera.org:8080/#/c/16770/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16770/2//COMMIT_MSG@14 PS2, Line 14: connection_negotiation_timeout_ms > To shorten the command line arguments could it be `negotiation_timeout_ms`? Yup, good idea: so far we don't have any other configurable parameter that would involve Kudu-specific negotiation process. Done. http://gerrit.cloudera.org:8080/#/c/16770/2/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/16770/2/src/kudu/tools/tool_action_common.cc@144 PS2, Line 144: DEFINE_int64(connection_negotiation_timeout_ms, 8000, > Any reason this value is different than the default rpc_negotiation_timeout Good question. Current default on the Kudu C++ client is 3 seconds as well, current settings for Java client is 10 seconds. I tried to use something in the middle, given that by default PRC timeout is 10 seconds for a Kudu C++ client: https://github.com/apache/kudu/blob/0e2c28864c27727c9723db7f319a5d7ebcbeead7/src/kudu/client/client.h#L259-L266 After some consideration, I guess keeping it 3 seconds would be a good idea if we want to preserve the behavior as seen in current versions. -- To view, visit http://gerrit.cloudera.org:8080/16770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5627517fd1da4f4d7472f1f0af810d741efe3390 Gerrit-Change-Number: 16770 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Comment-Date: Mon, 30 Nov 2020 05:13:59 +0000 Gerrit-HasComments: Yes
