Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16793
Change subject: [CLI] introduce connection negotiation timeout ...................................................................... [CLI] introduce connection negotiation timeout Since the connection negotiation timeout for Kudu client is now configurable (see KUDU-2966 and changelist 62ec1e474), it makes sense to allow using the new functionality in the kudu CLI tools. This changelist introduces a new command line option/flag --negotiation_timeout_ms to control the client-side connection negotiation timeout in the kudu CLI tools. The default value for the new flag is set to 3000 milliseconds to match the default connection negotiation timeout on the server. With larger and heavy loaded clusters it might be a good idea to the negotiation timeout if connection negotiation timeouts happen time to time. Also, it could help in cases where the RPC authentication is required and KDC is not fast enough. Keep in mind that the total RPC timeout includes the connection negotiation time, so in general it makes sense to bump --timeout_ms along with --negotiation_timeout_ms by the same delta. In addition, with this changeliest, all RPC-related kudu CLI tools except for `kudu local_replica copy_from_remote` now have command line arguments to control the RPC and the connection negotiation timeouts: * timeout_ms * negotiation_timeout_ms In addition, this patch also unifies the way how KuduClient instances are created in the kudu CLI code. I'm planning to take care of the RPC-related parameters of the `kudu local_replica copy_from_remote` tool in a separate patch. Change-Id: I5627517fd1da4f4d7472f1f0af810d741efe3390 more Change-Id: I3c5ed4b9ab5cb6d060424468f4c165827e196531 --- M src/kudu/integration-tests/replace_tablet-itest.cc M src/kudu/tools/ksck_checksum.cc M src/kudu/tools/ksck_remote.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/rebalancer_tool.cc M src/kudu/tools/rebalancer_tool.h M src/kudu/tools/tool_action.h M src/kudu/tools/tool_action_cluster.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_hms.cc M src/kudu/tools/tool_action_local_replica.cc M src/kudu/tools/tool_action_master.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/tools/tool_action_remote_replica.cc M src/kudu/tools/tool_action_table.cc M src/kudu/tools/tool_action_tablet.cc M src/kudu/tools/tool_action_tserver.cc M src/kudu/tools/tool_replica_util.cc 19 files changed, 518 insertions(+), 364 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/16793/1 -- To view, visit http://gerrit.cloudera.org:8080/16793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3c5ed4b9ab5cb6d060424468f4c165827e196531 Gerrit-Change-Number: 16793 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]>
