Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16776 )
Change subject: [build] Support and require C++17 ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/16776/11/docker/bootstrap-dev-env.sh File docker/bootstrap-dev-env.sh: http://gerrit.cloudera.org:8080/#/c/16776/11/docker/bootstrap-dev-env.sh@103 PS11, Line 103: centos-release-scl-rh > same as in the docs This is okay for docker given we don't have a redhat image and subscription we can use from docker. http://gerrit.cloudera.org:8080/#/c/16776/11/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/16776/11/docs/installation.adoc@104 PS11, Line 104: $ sudo yum install centos-release-scl-rh > This works only on CentOS, on RHEL it's a bit different it seems: https://d I updated the docs to reflect this. -- To view, visit http://gerrit.cloudera.org:8080/16776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15312473bda8c743eac228cd23c337fae5acf99d Gerrit-Change-Number: 16776 Gerrit-PatchSet: 11 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 30 Nov 2020 17:46:59 +0000 Gerrit-HasComments: Yes
