Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16776 )
Change subject: [build] Support and require C++17 ...................................................................... [build] Support and require C++17 This patch adjust the build to start supporting and requiring C++17 (therefore GCC 7+). It adjusts the documentation and supported OS matrix to match the new requirements as well. I needed to replace std::random_shuffle with std::shuffle. In C++14 `std::random_shuffle` is deprectated and in C++17 it is removed all together. This patch replaces `std::random_shuffle` with `std::shuffle` passing in a generator. Additionally I needed to patch libev due to a small C++17 incompatibility: https://github.com/enki/libev/pull/8 Change-Id: I15312473bda8c743eac228cd23c337fae5acf99d Reviewed-on: http://gerrit.cloudera.org:8080/16776 Reviewed-by: Attila Bukor <[email protected]> Tested-by: Grant Henke <[email protected]> --- M CMakeLists.txt M README.adoc R build-support/ccache-devtoolset-8/c++ R build-support/ccache-devtoolset-8/cc M build-support/enable_devtoolset.sh M build-support/enable_devtoolset_inner.sh M build-support/ubsan-blacklist.txt M docker/Dockerfile M docker/bootstrap-dev-env.sh M docs/installation.adoc M src/kudu/benchmarks/wal_hiccup.cc M src/kudu/client/client-test.cc M src/kudu/client/predicate-test.cc M src/kudu/client/symbols.map M src/kudu/common/wire_protocol-test.cc M src/kudu/fs/log_block_manager-test.cc M src/kudu/integration-tests/all_types-itest.cc M src/kudu/integration-tests/ts_itest-base.cc M src/kudu/master/catalog_manager.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/tablet.cc M src/kudu/transactions/txn_status_manager-test.cc M src/kudu/tserver/tablet_server-test.cc M thirdparty/build-definitions.sh M thirdparty/build-thirdparty.sh M thirdparty/download-thirdparty.sh A thirdparty/patches/libev-c17.patch M thirdparty/preflight.py 28 files changed, 145 insertions(+), 93 deletions(-) Approvals: Attila Bukor: Looks good to me, approved Grant Henke: Verified -- To view, visit http://gerrit.cloudera.org:8080/16776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I15312473bda8c743eac228cd23c337fae5acf99d Gerrit-Change-Number: 16776 Gerrit-PatchSet: 13 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
