Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16776 )
Change subject: [build] Support and require C++17 ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/16776/10//COMMIT_MSG Commit Message: PS10: > LLVM11 is not required for C++17 support. I will rebase and fix that patch Yes, I understand LLVM11 isn't required for C++17 support since LLVM9 supports C++17 already. I was just thinking that it would make sense to reverse the sequence because requiring C++17 looks like a breaking patch. -- To view, visit http://gerrit.cloudera.org:8080/16776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15312473bda8c743eac228cd23c337fae5acf99d Gerrit-Change-Number: 16776 Gerrit-PatchSet: 10 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 30 Nov 2020 19:22:08 +0000 Gerrit-HasComments: Yes
