Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG@7 PS2, Line 7: our own implementation Do we need to have the new function locale-aware like boost::iequals? https://www.boost.org/doc/libs/1_60_0/doc/html/boost/algorithm/iequals.html http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG@9 PS2, Line 9: boost::iequals with our own implementation Could you add a test to assess the performance of the new implementation compared with boost::iequals? -- To view, visit http://gerrit.cloudera.org:8080/16826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233 Gerrit-Change-Number: 16826 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 07 Dec 2020 20:51:32 +0000 Gerrit-HasComments: Yes
