Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG@7 PS2, Line 7: our own implementation > Do we need to have the new function locale-aware like boost::iequals? We don't need locale aware. All usage today is against known no-locale specific string values (flags, configs, tests, etc). http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG@9 PS2, Line 9: boost::iequals with our own implementation > Could you add a test to assess the performance of the new implementation co All usage is on non-performant sensitive code paths (flags, configs, tests, etc). http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case-test.cc File src/kudu/util/string_case-test.cc: http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case-test.cc@78 PS2, Line 78: ASSERT_TRUE(iequals(caps, mix)); > nit: only remaining combination that isn't tested is 'mix' and 'capital'. Done http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc File src/kudu/util/string_case.cc: http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc@87 PS2, Line 87: if (b.size() != a.size()) { > nit: from a consistency point of view is it better to include curly braces Done -- To view, visit http://gerrit.cloudera.org:8080/16826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233 Gerrit-Change-Number: 16826 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Mon, 07 Dec 2020 22:58:59 +0000 Gerrit-HasComments: Yes
