Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation ...................................................................... Patch Set 5: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/16826/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16826/5//COMMIT_MSG@13 PS5, Line 13: ascii nit: ASCII http://gerrit.cloudera.org:8080/#/c/16826/5/src/kudu/util/string_case-test.cc File src/kudu/util/string_case-test.cc: http://gerrit.cloudera.org:8080/#/c/16826/5/src/kudu/util/string_case-test.cc@66 PS5, Line 66: string foo = "foo"; : string capital = "Foo"; : string caps = "FOO"; : string mix = "FoO"; : string zero = "FO0"; nit: if there is an idea to test for 'const' qualifier of the parameters of iequals() as well, maybe make these 'const string' http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc File src/kudu/util/string_case.cc: http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc@86 PS2, Line 86: DCHECK(IsAscii(*word)); > good idea. I added these checks to the other methods as well. Cool, thanks! -- To view, visit http://gerrit.cloudera.org:8080/16826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233 Gerrit-Change-Number: 16826 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 08 Dec 2020 04:04:35 +0000 Gerrit-HasComments: Yes
