Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16859 )
Change subject: [master] Range specific hashing at table creation time. ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/16859/1/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/16859/1/src/kudu/common/partition.h@167 PS1, Line 167: FromPBHelper For a public function it should be named that suggests what's actually being done. ExtractHashBucketSchemasFromPB() or such? http://gerrit.cloudera.org:8080/#/c/16859/1/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/16859/1/src/kudu/common/partition.cc@172 PS1, Line 172: hash_bucket std::move(hash_bucket) http://gerrit.cloudera.org:8080/#/c/16859/1/src/kudu/common/partition.cc@451 PS1, Line 451: DCHECK_EQ(range_hash_schemas.size(), bounds_with_hash_schemas.size() - split_rows.size()); I didn't understand this change. http://gerrit.cloudera.org:8080/#/c/16859/1/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/16859/1/src/kudu/integration-tests/table_locations-itest.cc@205 PS1, Line 205: PartitionSchemaPB_HashBucketSchemaPB* Nit: auto* http://gerrit.cloudera.org:8080/#/c/16859/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16859/1/src/kudu/master/catalog_manager.cc@1716 PS1, Line 1716: PerRangeHashBucketSchemasPB auto http://gerrit.cloudera.org:8080/#/c/16859/1/src/kudu/master/catalog_manager.cc@1722 PS1, Line 1722: hash_bucket_schemas std::move(hash_bucket_schemas) http://gerrit.cloudera.org:8080/#/c/16859/1/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/16859/1/src/kudu/master/master-test.cc@180 PS1, Line 180: const vector<vector<HashBucketSchema>>& range_hash_schema, Nit: This arg can be the last one with a default value to avoid changing existing callsites that don't need to be updated. -- To view, visit http://gerrit.cloudera.org:8080/16859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f0dcbc3324f8f2d6e99b4d169fdf5c7f7dff95d Gerrit-Change-Number: 16859 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 19:15:46 +0000 Gerrit-HasComments: Yes
