Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16859 )
Change subject: [master] Range specific hashing at table creation time. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16859/2/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/16859/2/src/kudu/common/partition.cc@418 PS2, Line 418: if (!split_rows.empty()) { : for (const auto& hash_schemas : range_hash_schemas) { : if (!hash_schemas.empty()) { : return Status::InvalidArgument("Both 'split_rows' and 'range_hash_schemas' cannot be " : "populated at the same time."); : } : } > I'm not sure I follow the second point. If split_rows is non-empty, shouldn Currently, the size of 'range_hash_schemas' matches 'range_bounds' through the client. So for each range_bound added, 'range_hash_schema' will either add an empty vector or a user defined schema. So if I add an additional check for 'range_hash_schema' to be empty if 'split_rows' is not empty, then with this new interface a user cannot define both 'range_bounds' and 'split_rows' simultaneously. Even if the user does not wish to define any hash schemas per range_bound, since an empty vector will be added to 'range_hash_schema' for that range, this additional check will fail if we wish to define 'split_rows' as well. -- To view, visit http://gerrit.cloudera.org:8080/16859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f0dcbc3324f8f2d6e99b4d169fdf5c7f7dff95d Gerrit-Change-Number: 16859 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 15 Dec 2020 00:39:35 +0000 Gerrit-HasComments: Yes
