Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16859 )
Change subject: [master] Range specific hashing at table creation time. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16859/2/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/16859/2/src/kudu/common/partition.cc@418 PS2, Line 418: if (!split_rows.empty()) { : for (const auto& hash_schemas : range_hash_schemas) { : if (!hash_schemas.empty()) { : return Status::InvalidArgument("Both 'split_rows' and 'range_hash_schemas' cannot be " : "populated at the same time."); : } : } > Currently, the size of 'range_hash_schemas' matches 'range_bounds' through > the client. Isn't this untrue if the user isn't using the new per-range hash schemas feature? Won't the existing range partitioning APIs still work and not add 'range_hash_schema'? I am under the impression the new interface will not support 'split_rows'. Maybe it'd help to post the client portion of your work. I'm under the assumption that only the following cases are possible: - The user is using the old API. 'split_rows' and 'range_bounds' are allowed, but not 'range_hash_schemas' - The user is using the new API. 'split_rows' is not allowed at all, but 'range_hash_schemas' is allowed. If 'range_hash_schemas' is an empty vector, this is equivalent to a vector of empty schemas. An empty schema is shorthand for using the table-wide default. Are either of these incorrect assumptions? If not, I don't see why we would allow 'split_rows' and 'range_bounds' to be set with a non-empty vector of 'range_hash_schemas', even if every hash schema were empty, given the whole point of disallowing 'split_rows' is that it confounds the mapping of 'range_hash_schemas' to bounds. -- To view, visit http://gerrit.cloudera.org:8080/16859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f0dcbc3324f8f2d6e99b4d169fdf5c7f7dff95d Gerrit-Change-Number: 16859 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 15 Dec 2020 01:45:03 +0000 Gerrit-HasComments: Yes
