Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16699 )
Change subject: KUDU-2612: fuzz transactional inserts ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16699/4/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16699/4/src/kudu/integration-tests/fuzz-itest.cc@1734 PS4, Line 1734: {TEST_BEGIN_TXN, 0}, : {TEST_INSERT_IGNORE, 1, 0}, : {TEST_FLUSH_OPS, 0}, : {TEST_COMMIT_TXN, 0}, : : {TEST_INSERT_PK_ONLY, 0, -1}, : {TEST_INSERT_IGNORE_PK_ONLY, 0, -1}, : {TEST_DELETE, 0}, : {TEST_FLUSH_OPS, -1}, > Right. This sequence found an issue, but I fixed the issue before finished I guess TestRandomFuzz* would hit the issue eventually, yes. It seems those hard-coded sequences are here to have guaranteed coverage for possible regressions of issues pointed once by these random sequences, and we rely on fuzzing not just around some 'core' patterns, but rather rely on generating some sequences eventually. From the other side, I'm curios why this chaos monkey hasn't hit the issue that you fixed with http://gerrit.cloudera.org:8080/16777 ? Anyways, thank you for the clarification! -- To view, visit http://gerrit.cloudera.org:8080/16699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I719d42327ab18fda874332c9d6e1ae34aca8e846 Gerrit-Change-Number: 16699 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 11 Dec 2020 20:16:42 +0000 Gerrit-HasComments: Yes
