Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16699 )
Change subject: KUDU-2612: fuzz transactional inserts ...................................................................... Patch Set 6: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16699/3/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16699/3/src/kudu/integration-tests/fuzz-itest.cc@1142 PS3, Line 1142: placeOrDie(&pendi > This is the CHECK at L1248 for PS5. Whoops, I overlooked this one. Thanks you for pointing at the right place! http://gerrit.cloudera.org:8080/#/c/16699/4/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16699/4/src/kudu/integration-tests/fuzz-itest.cc@1734 PS4, Line 1734: CreateTabletAndStartClusterWithSchema(CreateKeyValueTestSchema()); : RunFuzzCase({ : {TEST_INSERT, 1}, : {TEST_UPSERT, 1}, : {TEST_FLUSH_OPS}, : {TEST_FLUSH_TABLET}, : {TEST_UPSERT, 1}, : {TEST_DELETE, 1}, : {TEST_UPSERT, 1}, > I added this case because I found it helpful in finding https://gerrit.clou Exactly: my question was more on how to decide what fuzz sequences to add. I thought that once we know there is a sequence in ops that triggers an issue, it would make sense to add a test for the exact sequence and also 'fuzz' variations around the same 'core' pattern. Or there is some auto-fuzzing done for that already? -- To view, visit http://gerrit.cloudera.org:8080/16699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I719d42327ab18fda874332c9d6e1ae34aca8e846 Gerrit-Change-Number: 16699 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 11 Dec 2020 19:46:17 +0000 Gerrit-HasComments: Yes
