Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16699 )
Change subject: KUDU-2612: fuzz transactional inserts ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/16699/3/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16699/3/src/kudu/integration-tests/fuzz-itest.cc@1142 PS3, Line 1142: placeOrDie(&pendi > Not sure I see that CHECK() was added? This is the CHECK at L1248 for PS5. http://gerrit.cloudera.org:8080/#/c/16699/3/src/kudu/integration-tests/fuzz-itest.cc@1147 PS3, Line 1147: if (no_open_txns()) continue; > Not sure whether you missed this one or this doesn't make much sense? Ah indeed I missed this. Done http://gerrit.cloudera.org:8080/#/c/16699/4/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16699/4/src/kudu/integration-tests/fuzz-itest.cc@1734 PS4, Line 1734: CreateTabletAndStartClusterWithSchema(CreateKeyValueTestSchema()); : RunFuzzCase({ : {TEST_INSERT, 1}, : {TEST_UPSERT, 1}, : {TEST_FLUSH_OPS}, : {TEST_FLUSH_TABLET}, : {TEST_UPSERT, 1}, : {TEST_DELETE, 1}, : {TEST_UPSERT, 1}, > Does it make sense to add TEST_UPDATE and MINOR_COMPACT_DELTAS into the seq I added this case because I found it helpful in finding https://gerrit.cloudera.org/c/16691/ so I'll leave this case as is. What in particular would we be trying to test? -- To view, visit http://gerrit.cloudera.org:8080/16699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I719d42327ab18fda874332c9d6e1ae34aca8e846 Gerrit-Change-Number: 16699 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 11 Dec 2020 19:23:50 +0000 Gerrit-HasComments: Yes
