Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16858 )
Change subject: [server] add 'uptime' metric for server ...................................................................... Patch Set 4: > > Looks like the test failure is relevant: > > > > F1212 02:58:27.233850 17340 server_base.h:120] Check failed: > > start_time_ > MonoTime::Min() > > *** Check failure stack trace: *** > > @ 0x7ff90413788d google::LogMessage::Fail() at ??:0 > > @ 0x7ff904139862 google::LogMessage::SendToLog() at ??:0 > > @ 0x7ff9041373ad google::LogMessage::Flush() at ??:0 > > @ 0x7ff90413a279 google::LogMessageFatal::~LogMessageFatal() > > at ??:0 > > @ 0x7ff902954ee2 kudu::server::ServerBase::start_time() at > > ??:0 > > @ 0x7ff90294caa1 > > _ZZN4kudu6server10ServerBaseC4ENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEERKNS0_17ServerBaseOptionsERKS7_ENKUlvE_clEv > > at ??:0 > > @ 0x7ff902952405 > > _ZNSt17_Function_handlerIFlvEZN4kudu6server10ServerBaseC4ENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEERKNS2_17ServerBaseOptionsERKS9_EUlvE_E9_M_invokeERKSt9_Any_data > > at ??:0 > > @ 0x7ff90295d140 std::function<>::operator()() at ??:0 > > @ 0x7ff90295bc05 kudu::FunctionGauge<>::value() at ??:0 > > @ 0x7ff902959d46 kudu::FunctionGauge<>::DetachToCurrentValue() > > at ??:0 > > @ 0x7ff90295779f > > _ZZN4kudu13FunctionGaugeIlE21AutoDetachToLastValueEPNS_21FunctionGaugeDetacherEENKUlvE_clEv > > at ??:0 > > @ 0x7ff90295bd8b > > _ZNSt17_Function_handlerIFvvEZN4kudu13FunctionGaugeIlE21AutoDetachToLastValueEPNS1_21FunctionGaugeDetacherEEUlvE_E9_M_invokeERKSt9_Any_data > > at ??:0 > > @ 0x7ff9050364a4 std::function<>::operator()() at ??:0 > > @ 0x7ff904accca8 kudu::FunctionGaugeDetacher::~FunctionGaugeDetacher() > > at ??:0 > > @ 0x7ff90294dae8 kudu::server::ServerBase::~ServerBase() at > > ??:0 > > @ 0x7ff904fdee0a kudu::kserver::KuduServer::~KuduServer() at > > ??:0 > > @ 0x7ff904fd8c7a kudu::master::Master::~Master() at ??:0 > > @ 0x7ff904ffeef2 kudu::master::RunMasterServer() at ??:0 > > @ 0x5561fd8365ef kudu::master::MasterMain() at ??:0 > > @ 0x5561fd8367f5 main at ??:0 > > @ 0x7ff9035b6bf7 __libc_start_main at ??:0 > > @ 0x5561fd83621a _start at ??:0 > > /home/jenkins-slave/workspace/kudu-master/0/src/kudu/integration-tests/security-faults-itest.cc:194: > > Failure > > Value of: s.ToString() > > Right, and that's a sign that we don't need DCHECK there :) The issue there is that in that test scenario the metrics detacher tries to capture the value of the metric before start time is assigned. -- To view, visit http://gerrit.cloudera.org:8080/16858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb362a71c625c05a2185b95ec24d3f371dcb4155 Gerrit-Change-Number: 16858 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 12 Dec 2020 04:19:15 +0000 Gerrit-HasComments: No
