Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16858 )
Change subject: [server] add 'uptime' metric for server ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16858/3/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/16858/3/src/kudu/server/server_base.cc@422 PS3, Line 422: return (MonoTime::Now() - this->start_time()) nit: would it make sense to DCHECK that start_time has been set? -- To view, visit http://gerrit.cloudera.org:8080/16858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb362a71c625c05a2185b95ec24d3f371dcb4155 Gerrit-Change-Number: 16858 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 12 Dec 2020 02:26:48 +0000 Gerrit-HasComments: Yes
