Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16858 to look at the new patch set (#2). Change subject: [server] add 'uptime' metric for server ...................................................................... [server] add 'uptime' metric for server This patch adds a new 'uptime' metric for a Kudu server. The metric's value is reported as the duration of the time interval passed from the start of the server. The interval duration is reported in microseconds as many other time-related metrics. Initially I thought to reuse already existing field that stores server's start time as wall clock time in seconds, but such approach would not produce a reliable result given that the wall clock time can be set any time by a super user, hence a wall-clock-based delta could not reliably provide the actual uptime of a server. The motivation for this patch is the realization that sometimes it's not easy to interpret metric values reported for a server without knowing its uptime. I didn't add any tests for the newly introduced metric, but I manually verified that both kudu-master and kudu-tserver processes report uptime among their metrics at the "/metrics" HTTP endpoint. Change-Id: Idb362a71c625c05a2185b95ec24d3f371dcb4155 --- M src/kudu/common/wire_protocol.proto M src/kudu/integration-tests/registration-test.cc M src/kudu/master/master.cc M src/kudu/server/server_base.cc M src/kudu/server/server_base.h M src/kudu/tserver/heartbeater.cc 6 files changed, 43 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/16858/2 -- To view, visit http://gerrit.cloudera.org:8080/16858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb362a71c625c05a2185b95ec24d3f371dcb4155 Gerrit-Change-Number: 16858 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120)