Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

I'm building on a couple of my build environments (Mac and CentOS 7) just for 
coverage.

http://gerrit.cloudera.org:8080/#/c/16878/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16878/1//COMMIT_MSG@7
PS1, Line 7: fix building 3rd-party
nit: maybe more specifically, fix building boost?


http://gerrit.cloudera.org:8080/#/c/16878/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

http://gerrit.cloudera.org:8080/#/c/16878/1/thirdparty/build-definitions.sh@850
PS1, Line 850: $CC -v
Wow, nice. I assumed the output was the same as --version. Neat!



--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 07:06:08 +0000
Gerrit-HasComments: Yes

Reply via email to