Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+2
>
> I was able to build thirdparty on macOS 10.15.7 and CentOS 7.3 -- not SLES, 
> but at least it doesn't break other environments. Would be good to wait for 
> others who may be testing on SLES to review.

Actually running cmake, I hit this error:

Checking for C++17 compiler support ...
*** Unable to compile a simple c++17 program. Please use g++ 7.0 or higher (or 
CLANG 6.0 or higher). On CentOS 7 or RHEL 7 you must use the devtoolset. See 
docs/installation.adoc for more info.
Compilation failed: In file included from <stdin>:2:
In file included from 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/optional:150:
In file included from 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__debug:14:
In file included from 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:95:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/wchar.h:118:15:
 fatal error: 'wchar.h' file not found
#include_next <wchar.h>
              ^~~~~~~~~
1 error generated.

Will investigate further tomorrow.


--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 09:09:51 +0000
Gerrit-HasComments: No

Reply via email to