Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16878 )
Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8 ...................................................................... [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8 This patch updates build-definitions.sh to allow building on SLES 12.5 (SUSE Linux Enterprise Server 12 SP5) with GCC 8. The stock C/C++ compiler on SLES 12 doesn't support C++17 features now required to build Kudu, so one option is to use gcc/g++-8. Another option might be building with Development Tools Module [1], but I guess it's nice to be able to build Kudu with just other/newer C++ compiler at first. I used the following script to build all thirdparty components from Kudu workspace root: ------------------- CC=/usr/bin/gcc-8 CXX=/usr/bin/g++-8 env CC=$CC CXX=$CXX \ ./build-support/enable_devtoolset.sh thirdparty/build-if-necessary.sh all ------------------- [1] https://www.suse.com/c/suse-linux-essentials-where-are-the-compilers-understanding-the-development-tools-module/ Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7 Reviewed-on: http://gerrit.cloudera.org:8080/16878 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Grant Henke <[email protected]> --- M thirdparty/build-definitions.sh 1 file changed, 17 insertions(+), 10 deletions(-) Approvals: Alexey Serbin: Verified Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7 Gerrit-Change-Number: 16878 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
