Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16830 )
Change subject: [consensus] KUDU-2181 Allow sending status msgs to FAILED peers ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/16830/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16830/5//COMMIT_MSG@32 PS5, Line 32: Verify the new master is promoted as VOTER What if it's not promoted to a voter role? What's the recovery scenario? http://gerrit.cloudera.org:8080/#/c/16830/5/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16830/5/src/kudu/master/dynamic_multi_master-test.cc@168 PS5, Line 168: Need to create around 1k tables even with lowest flush threshold and log segment size. Might it be helpful to add dimension_label for a table to decrease the number of tables to create? I recall that helped with a test scenario to reproduce KUDU-3036: https://github.com/apache/kudu/commit/b4c317299f39ae0530cb10702e540cd22393656c There are also options to use extra_config and comment for a column if thinking to increase per-table amount of data in the system catalog. -- To view, visit http://gerrit.cloudera.org:8080/16830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I142c1dec442ec72c38c5be9d62cdf270e441d6e3 Gerrit-Change-Number: 16830 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Dec 2020 22:14:48 +0000 Gerrit-HasComments: Yes
