Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16830 )
Change subject: [master] KUDU-2181 Procedure for copying sys catalog on adding master ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/16830/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16830/6//COMMIT_MSG@26 PS6, Line 26: If not, : above steps will have to be repeated. Curious, do we actually expect this to happen? How could an operator get into this scenario? http://gerrit.cloudera.org:8080/#/c/16830/6/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16830/6/src/kudu/master/dynamic_multi_master-test.cc@172 PS6, Line 172: MonoTime deadline = MonoTime::Now() + MonoDelta::FromSeconds(2); If you haven't already, it'd be good to run this test suite a couple thousand times, maybe in ASAN or TSAN mode, maybe with --stress_cpu_threads=4 to make sure this won't be flaky. http://gerrit.cloudera.org:8080/#/c/16830/6/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/16830/6/src/kudu/master/sys_catalog.cc@101 PS6, Line 101: unsafe nit: probably should be advanced instead of unsafe, given we want this to be used as a part of documented workflow. -- To view, visit http://gerrit.cloudera.org:8080/16830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I142c1dec442ec72c38c5be9d62cdf270e441d6e3 Gerrit-Change-Number: 16830 Gerrit-PatchSet: 6 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 04 Jan 2021 07:04:41 +0000 Gerrit-HasComments: Yes
