Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16830 )
Change subject: [consensus] KUDU-2181 Allow sending status msgs to FAILED peers ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/16830/5/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16830/5/src/kudu/master/dynamic_multi_master-test.cc@424 PS5, Line 424: for (int i = 0; i < migrated_cluster.num_masters(); i++) { : ASSERT_OK(migrated_cluster.master(i)->WaitForCatalogManager()); : } nit: does it makes sense to ensure that new_master_ is now a part of masters returned by migrated_cluster.master(i), i.e. that UUID returned by new_master_->uuid() is among those which are in migrated_cluster? http://gerrit.cloudera.org:8080/#/c/16830/5/src/kudu/master/dynamic_multi_master-test.cc@438 PS5, Line 438: ASSERT_EQ(1, master.registration().rpc_addresses_size()); : HostPort actual_hp = HostPortFromPB(master.registration().rpc_addresses(0)); : ASSERT_TRUE(std::find(master_hps.begin(), master_hps.end(), actual_hp) != master_hps.end()); : Does it make sense to check there aren't any duplicates among the registered RPC master addresses in the migrated cluster? http://gerrit.cloudera.org:8080/#/c/16830/5/src/kudu/master/dynamic_multi_master-test.cc@467 PS5, Line 467: master one nit: one master http://gerrit.cloudera.org:8080/#/c/16830/5/src/kudu/master/dynamic_multi_master-test.cc@475 PS5, Line 475: kTableName To harden the use case, does it make sense to try opening a table that was created at the previous iteration of this cycle, if any (i.e. start opening "table-0" at iteration 1 instead of "first_table", and so on)? -- To view, visit http://gerrit.cloudera.org:8080/16830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I142c1dec442ec72c38c5be9d62cdf270e441d6e3 Gerrit-Change-Number: 16830 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Dec 2020 22:46:48 +0000 Gerrit-HasComments: Yes
