Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@687 PS1, Line 687: (looking at you, SLES12's /usr/lib/mit/bin/krb5-config) :) http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@700 PS1, Line 700: fi : Would it have helped in debugging to have logged KRGB5CONFIG here? Or is this clear from existing logging? -- To view, visit http://gerrit.cloudera.org:8080/16883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6 Gerrit-Change-Number: 16883 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 16 Dec 2020 19:25:33 +0000 Gerrit-HasComments: Yes
