Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@700 PS1, Line 700: fi : > It's not a problem to have empty KRB5CONFIG if the curl is smart enough to I meant that curl might be able to guess on the location of the krb5-config elsewhere, so having KRB5CONFIG empty might be not a problem elsewhere but on SLES. And yes: we know that our current version of curl isn't able to detect krb5-config on SLES, so I guess we don't need to check if curl is smart enough in case of SLES :) -- To view, visit http://gerrit.cloudera.org:8080/16883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6 Gerrit-Change-Number: 16883 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 16 Dec 2020 20:01:44 +0000 Gerrit-HasComments: Yes
