Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16883 )
Change subject: [thirdparty] Fix curl build on SLES ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/16883/1/thirdparty/build-definitions.sh@700 PS1, Line 700: fi : > It was logged in my environment given all the called exports are logged via Right, though before this patch, there was no such export, and we found ourselves missing KRGB5CONFIG. Was it obvious then that KRGB5CONFIG was important and empty? If not, it might be worth adding a print statement here, in case we find ourselves with no KRGB5CONFIG, e.g. because SLES_KRB5CONFIG_LOCATION is missing -- To view, visit http://gerrit.cloudera.org:8080/16883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0961865a00601431bbc833360590cafa3aaf65c6 Gerrit-Change-Number: 16883 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 16 Dec 2020 19:46:29 +0000 Gerrit-HasComments: Yes
