Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16859 )
Change subject: [master] Range specific hashing at table creation time. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16859/4/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/16859/4/src/kudu/common/partition-test.cc@1157 PS4, Line 1157: struct PartitionData { > Should I refactor other test cases in this test file to include this vector > of structs? I don't feel strongly about it; let's start with the tests in this patch though. If you do decide to update the others, please do so in a separate patch. > It got me thinking about the fields of the Partition class, since in the > PartitionDebugString() method it prints the hash bucket schemas for each > partition by accessing the 'hash_bucket_schemas_' field of the > PartitionSchema class. Currently, a Partition object has fields for its hash > buckets and both the start and end of its partition key. With this new > feature and the current design, there is no way to access the entire hash > schema(s) per a range. Basically, the missing parts are the columns that are > hashed on and the hash seed. Maybe I'm missing something -- why do you need to access the hash schemas per range from the Partition? It already doesn't have information about column IDs, even without this new feature. Correct me if I'm wrong, but I'm assuming if we have a Partition, we also have a corresponding PartitionSchema, since the Partition itself is about as stripped down as it can be to represent a single partition. -- To view, visit http://gerrit.cloudera.org:8080/16859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f0dcbc3324f8f2d6e99b4d169fdf5c7f7dff95d Gerrit-Change-Number: 16859 Gerrit-PatchSet: 5 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 17 Dec 2020 00:20:00 +0000 Gerrit-HasComments: Yes
