Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16859 )
Change subject: [master] Range specific hashing at table creation time. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16859/4/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/16859/4/src/kudu/common/partition-test.cc@1157 PS4, Line 1157: struct PartitionData { > > Maybe I'm missing something -- why do you need to access the hash schemas I see, thanks for clarifying. It'd depend on how we intend on using PartitionSchema moving forward. I think it makes sense to continue separating the concerns of Partition and PartitionSchema -- PartitionSchema worries about metadata that's shared between partitions, Partitions are descriptors that rely on a PartitionSchema. Rather than extending the purview of Partition, conceptually I'd prefer we instead either extend PartitionSchema, or even use multiple PartitionSchemas for tables that have per-range schemas, in which each PartitionSchemas would have the same RangeSchema, but correspond to different bounds. Whether or not the implementation will allow that cleanly is a different question, but for now, I don't think it's worth adding. Unless, of course, you're going to need it very soon. -- To view, visit http://gerrit.cloudera.org:8080/16859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f0dcbc3324f8f2d6e99b4d169fdf5c7f7dff95d Gerrit-Change-Number: 16859 Gerrit-PatchSet: 5 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 17 Dec 2020 01:03:28 +0000 Gerrit-HasComments: Yes
