Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16859 )
Change subject: [master] Range specific hashing at table creation time. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16859/4/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/16859/4/src/kudu/common/partition-test.cc@1157 PS4, Line 1157: struct PartitionData { > Maybe I'm missing something -- why do you need to access the hash schemas per > range from the Partition? It already doesn't have information about column > IDs, even without this new feature. Correct me if I'm wrong, but I'm assuming > if we have a Partition, we also have a corresponding PartitionSchema, since > the Partition itself is about as stripped down as it can be to represent a > single partition. The reason it doesn't have information about column IDs is because PartitionSchema has the relevant information about the hash schemas. With this new feature, PartitionSchema would only contain the table wide hash schemas and not the schemas per each range. And yes, the set of Partitions returned from CreatePartitions() have a corresponding PartitionSchema. As for why we would need to access the hash schemas per range, I don't have a good answer for that. I just thought about this whole going through previous test cases, so I'll probably have to look into this some more to see if additional fields are even necessary. -- To view, visit http://gerrit.cloudera.org:8080/16859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f0dcbc3324f8f2d6e99b4d169fdf5c7f7dff95d Gerrit-Change-Number: 16859 Gerrit-PatchSet: 5 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 17 Dec 2020 00:49:05 +0000 Gerrit-HasComments: Yes
