Hello Mahesh Reddy, Tidy Bot, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16916
to look at the new patch set (#3).
Change subject: [rpc] update ServiceIf::service_name() signature
......................................................................
[rpc] update ServiceIf::service_name() signature
This patch changes the signature of the ServiceIf::service_name() method
to return 'const std::string&' instead of 'std::string' and updates a few
related call sites accordingly. In addition, this patch removes unused
ServiceIf::methods_by_name() accessor method and makes
ServiceIf::ParseParam() and ServiceIf::RespondBadMethod() methods
static.
The ServiceIf::service_name() method isn't in any hot path but it's used
in ServicePool::RejectTooBusy(). The latter is usually called under
high memory pressure when it's preferred to avoid memory allocations
at least because of the lock contention in the tcmalloc library.
I also did a few formatting changes in protoc-gen-krpc.cc to improve
the readability of the auto-generated code since I looked at that code
recently.
Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
---
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/service_if.cc
M src/kudu/rpc/service_if.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_pool.h
M src/kudu/server/rpc_server.cc
7 files changed, 278 insertions(+), 271 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/16916/3
--
To view, visit http://gerrit.cloudera.org:8080/16916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Gerrit-Change-Number: 16916
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Tidy Bot (241)
