Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16916 )
Change subject: [rpc] update ServiceIf::service_name() signature ...................................................................... Patch Set 3: (1 comment) Thank you for the review! http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/service_if.h File src/kudu/rpc/service_if.h: http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/service_if.h@118 PS3, Line 118: explicit GeneratedServiceIf(const scoped_refptr<ResultTracker>& tracker); > Not quite sure I understand the reasoning/context behind adding this, every Ah, that's to use initializer-list style syntax in the constructor of the auto-generated service skeleton class in https://gerrit.cloudera.org/#/c/16916/3/src/kudu/rpc/protoc-gen-krpc.cc@486 Prior to this, it was necessary to have an assignment in the constructor of the service skeleton class after the field was already initialized in the constructor of the base (i.e. GeneratedServiceIf) class. -- To view, visit http://gerrit.cloudera.org:8080/16916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489 Gerrit-Change-Number: 16916 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 05 Jan 2021 02:44:50 +0000 Gerrit-HasComments: Yes
