Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16916 )
Change subject: [rpc] update ServiceIf::service_name() signature ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Thanks for the update! http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h File src/kudu/rpc/rpc-test-base.h: http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h@59 PS3, Line 59: using kudu::rpc_test::AddRequestPB; > I'm not going to address this: this is test-only code and this header is us Ack -- To view, visit http://gerrit.cloudera.org:8080/16916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489 Gerrit-Change-Number: 16916 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 05 Jan 2021 18:46:30 +0000 Gerrit-HasComments: Yes
