Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13004 )
Change subject: [build] Fix the java compatibility checker script ...................................................................... Patch Set 3: Code-Review+1 (3 comments) Looks good overall, just a few nits. http://gerrit.cloudera.org:8080/#/c/13004/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13004/3//COMMIT_MSG@22 PS3, Line 22: incorparate incorporate ? http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py File build-support/check_compatibility.py: http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@109 PS3, Line 109: if os.path.exists(get_japicmp_path()): : logging.info("japicmp is already downloaded.") Will it work as expected when a new version of the tool is available? Maybe, it makes sense to switch to a filename that matches the name of the downloaded JAR? http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@115 PS3, Line 115: "curl", "-o" nit: does it make sense to add few options to match the behavior of downloading source packages in thirdparty? Something like curl --retry 3 -L -o ... -- To view, visit http://gerrit.cloudera.org:8080/13004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id482da0b3aa5ea35fcfb2b674f0d7ae413045ca3 Gerrit-Change-Number: 13004 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 08 Jan 2021 22:38:55 +0000 Gerrit-HasComments: Yes
