Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/13004 )
Change subject: [build] Fix the java compatibility checker script ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py File build-support/check_compatibility.py: http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@121 PS3, Line 121: return [j for j in all_jars if ( Nit: if I am reading this correctly, this code is excluding 9 patterns in order to find 6 files. Wouldn't it be easier include instead of exclude? -- To view, visit http://gerrit.cloudera.org:8080/13004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id482da0b3aa5ea35fcfb2b674f0d7ae413045ca3 Gerrit-Change-Number: 13004 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 08 Jan 2021 22:44:22 +0000 Gerrit-HasComments: Yes
