Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13004 )
Change subject: [build] Fix the java compatibility checker script ...................................................................... [build] Fix the java compatibility checker script This patch fixes check_compatibility.py. Primarily it changed the existing script to use the Gradle build in place of the Maven build that no longer exists. It now uses japicmp in place of java_acc because java_acc had issues unzipping the jars created by the kudu build. Additionally japicmp’s filtering seemed to work better. The patch also updates the Gradle build to ensure generated Protobuf classes are annotated with @Generated to make report filtering easier. In follow on patches I may incorporate this into the LINT job and cause failure on API breakage. Change-Id: Id482da0b3aa5ea35fcfb2b674f0d7ae413045ca3 Reviewed-on: http://gerrit.cloudera.org:8080/13004 Tested-by: Kudu Jenkins Reviewed-by: Greg Solovyev <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M build-support/check_compatibility.py M java/gradle/protobuf.gradle 2 files changed, 111 insertions(+), 91 deletions(-) Approvals: Kudu Jenkins: Verified Greg Solovyev: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id482da0b3aa5ea35fcfb2b674f0d7ae413045ca3 Gerrit-Change-Number: 13004 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
