Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16940 )
Change subject: [java] Add JAAS example to client API doc ...................................................................... Patch Set 3: Code-Review+1 (3 comments) Just a couple more nits http://gerrit.cloudera.org:8080/#/c/16940/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/16940/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@195 PS3, Line 195: n nit: add a comma http://gerrit.cloudera.org:8080/#/c/16940/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@201 PS3, Line 201: * KuduClient client = myClient I'm curious, can we declare 'client' outside of the doAs and interact with the client outside of this block, in the same way we could if using UGI? If so, maybe update the example to it, so these blocks are as apples-to-apples as they can get. http://gerrit.cloudera.org:8080/#/c/16940/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@206 PS3, Line 206: relogin nit: "re-login" for consistency -- To view, visit http://gerrit.cloudera.org:8080/16940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7db5bf67727f7318272de7ea2156a33255a2dc8b Gerrit-Change-Number: 16940 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Jan 2021 21:49:57 +0000 Gerrit-HasComments: Yes
