Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16940 )
Change subject: [java] Add JAAS example to client API doc ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/16940/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/16940/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@195 PS3, Line 195: n, > nit: add a comma Done http://gerrit.cloudera.org:8080/#/c/16940/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@201 PS3, Line 201: * (P > I'm curious, can we declare 'client' outside of the doAs and interact with Yea that makes sense, thanks for the tip. I just tried it that way and it works too. Updated. http://gerrit.cloudera.org:8080/#/c/16940/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@206 PS3, Line 206: > nit: "re-login" for consistency Done -- To view, visit http://gerrit.cloudera.org:8080/16940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7db5bf67727f7318272de7ea2156a33255a2dc8b Gerrit-Change-Number: 16940 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Jan 2021 22:02:10 +0000 Gerrit-HasComments: Yes
