Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16953 )
Change subject: [build] Separate protobuf java compilation into a seperate module ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/16953/2/build-support/check_compatibility.py File build-support/check_compatibility.py: http://gerrit.cloudera.org:8080/#/c/16953/2/build-support/check_compatibility.py@135 PS2, Line 135: kudu-rpc kudu-proto ? http://gerrit.cloudera.org:8080/#/c/16953/2/java/kudu-client/build.gradle File java/kudu-client/build.gradle: http://gerrit.cloudera.org:8080/#/c/16953/2/java/kudu-client/build.gradle@22 PS2, Line 22: compile Just to make sure: this will result in shading this dependency in kudu-client, right? http://gerrit.cloudera.org:8080/#/c/16953/2/java/kudu-client/build.gradle@35 PS2, Line 35: compile libs.protobufJava Do we need to specify this explicitly once moving kudu-proto into a separate module? http://gerrit.cloudera.org:8080/#/c/16953/2/java/kudu-proto/build.gradle File java/kudu-proto/build.gradle: http://gerrit.cloudera.org:8080/#/c/16953/2/java/kudu-proto/build.gradle@35 PS2, Line 35: kudu-rpc kudu-proto http://gerrit.cloudera.org:8080/#/c/16953/2/java/kudu-proto/build.gradle@40 PS2, Line 40: kudu-rpc kudu-proto http://gerrit.cloudera.org:8080/#/c/16953/2/java/kudu-subprocess/build.gradle File java/kudu-subprocess/build.gradle: http://gerrit.cloudera.org:8080/#/c/16953/2/java/kudu-subprocess/build.gradle@32 PS2, Line 32: compile libs.protobufJava : compile libs.protobufJavaUtil I'm not an expert in gradle, so just wanted to clarify: wouldn't these be included as transitive dependencies from kudu-proto? Or that's just to make shade these? -- To view, visit http://gerrit.cloudera.org:8080/16953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib83db74c4a09cdd597bee90f5124ed804adac42d Gerrit-Change-Number: 16953 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 15 Jan 2021 18:28:05 +0000 Gerrit-HasComments: Yes
