Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16953 )
Change subject: [build] Separate protobuf java compilation into a seperate module ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG Commit Message: PS1: > I'm curious how you spotted this. Just noticed it going through build logs? Done PS1: > Nevermind, I see it from the code coverage test. Done http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG@7 PS1, Line 7: [build] Seperate protobuf java compilation into a seperate module > nit: separate, same elsewhere Done http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG@15 PS1, Line 15: the `kudu-rpc` module in API compatibility and test > It's true that it's the most accurate for now, but isn't it possible that w The jar is not published, so we can change the name at any time. I will go with kudu-proto for now. -- To view, visit http://gerrit.cloudera.org:8080/16953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib83db74c4a09cdd597bee90f5124ed804adac42d Gerrit-Change-Number: 16953 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 15 Jan 2021 15:00:27 +0000 Gerrit-HasComments: Yes
