Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16969 )
Change subject: [java] address warnings from the SonarLint tool ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java File java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java: http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java@118 PS1, Line 118: return length == that.length; I am not sure I prefer this syntax to the existing syntax. Do you think it's better? If so why? http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java: http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java@51 PS1, Line 51: int numRows) { I think reuseRowResult was kept around for compatibility concerns. It would be good to go back and validate. http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java: http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java@75 PS1, Line 75: private AsyncUtil() { Should this go at the top of the class? Here and elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/16969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Gerrit-Change-Number: 16969 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Comment-Date: Mon, 25 Jan 2021 16:35:45 +0000 Gerrit-HasComments: Yes
