Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16969 )
Change subject: [java] address warnings from the SonarLint tool ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java: http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java@51 PS1, Line 51: int numRows) { > Thank you for pointing at this. That makes sense. It looks like this is okay to change. Thanks for looking into it. http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java: http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java@75 PS1, Line 75: private AsyncUtil() { > I put this in the very end of the file to match what we already have in the I generally expect to see constructors, if there are any, at the top of the class. Ultimately this is a nit, and I am okay with it either way. The google style guide isn't as concrete on this, but the oracle guide suggests that constructors should come before methods. https://google.github.io/styleguide/javaguide.html#s3.4.2-ordering-class-contents https://www.oracle.com/java/technologies/javase/codeconventions-fileorganization.html#1852 -- To view, visit http://gerrit.cloudera.org:8080/16969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Gerrit-Change-Number: 16969 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Comment-Date: Thu, 28 Jan 2021 16:07:17 +0000 Gerrit-HasComments: Yes
