Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16969 )
Change subject: [java] address warnings from the SonarLint tool ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java: http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java@75 PS1, Line 75: return ((Deferred) deferred).addBothDeferring(callback); > I generally expect to see constructors, if there are any, at the top of the OK, I moved constructors to the top. -- To view, visit http://gerrit.cloudera.org:8080/16969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Gerrit-Change-Number: 16969 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 29 Jan 2021 06:19:45 +0000 Gerrit-HasComments: Yes
