Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17108 )
Change subject: [master] Fix validation for NON_VOTER on adding a master ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17108/1/src/kudu/master/master.h File src/kudu/master/master.h: http://gerrit.cloudera.org:8080/#/c/17108/1/src/kudu/master/master.h@124 PS1, Line 124: bool include_all = false, : consensus::RaftPeerPB::MemberType member_type = consensus::RaftPeerPB::VOTER I don't see it ever used in combination of 'false', 'NON_VOTER'. Does it make sense to replace these two parameters with one of custom enum type, so the values are: enum MasterType { ALL, VOTER_ONLY, }; where the default stays as 'MasterType::VOTER_ONLY'? -- To view, visit http://gerrit.cloudera.org:8080/17108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10e6b3617b032c74ebed4359b10c36b7b365d9b7 Gerrit-Change-Number: 17108 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 23 Feb 2021 07:22:35 +0000 Gerrit-HasComments: Yes
