Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17108 )
Change subject: [master] Fix validation for NON_VOTER on adding a master ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17108/1/src/kudu/master/master.h File src/kudu/master/master.h: http://gerrit.cloudera.org:8080/#/c/17108/1/src/kudu/master/master.h@124 PS1, Line 124: Status GetMasterHostPorts(std::vector<HostPort>* hostports, MasterType type = VOTER_ONLY) const; : > I don't see it ever used in combination of 'false', 'NON_VOTER'. Does it m Okay. I wish though the enums were numbered in powers of 2 to allow OR'ing them and checking for all. -- To view, visit http://gerrit.cloudera.org:8080/17108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10e6b3617b032c74ebed4359b10c36b7b365d9b7 Gerrit-Change-Number: 17108 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 23 Feb 2021 18:21:17 +0000 Gerrit-HasComments: Yes
