Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17108 )
Change subject: [master] Fix validation for NON_VOTER on adding a master ...................................................................... [master] Fix validation for NON_VOTER on adding a master When a master is added, validation check is made whether the supplied master is already part of the Raft configuration. However this check doesn't include NON_VOTER masters and hence an InvalidArgument error is thrown later by the ChangeConfig implementation in Raft. "master add" CLI is designed to specifically catch Status::AlreadyPresent error to allow retries. This change basically checks for all masters in the committed Raft config irrespective of the member type on adding a master. Change-Id: I10e6b3617b032c74ebed4359b10c36b7b365d9b7 Reviewed-on: http://gerrit.cloudera.org:8080/17108 Tested-by: Bankim Bhavsar <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/master/dynamic_multi_master-test.cc M src/kudu/master/master.cc M src/kudu/master/master.h 3 files changed, 34 insertions(+), 6 deletions(-) Approvals: Bankim Bhavsar: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I10e6b3617b032c74ebed4359b10c36b7b365d9b7 Gerrit-Change-Number: 17108 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
