Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17175 )
Change subject: [tool] Add the missing "member_type" in help text of list master CLI ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17175/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17175/1/src/kudu/tools/kudu-tool-test.cc@3347 PS1, Line 3347: VOTER > If it were a non-voter, what should be the output? Is this supposed to fai In what case would a single master configuration have a master that's not a VOTER or not a LEADER? >From the code it looks pretty straightforward. https://github.com/apache/kudu/blob/master/src/kudu/master/sys_catalog.cc#L351 Or would you rather prefer we check for all possible enum values because in this case we don't really care what specific value it is as long as it is one of the valid enum values? -- To view, visit http://gerrit.cloudera.org:8080/17175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00f349687866269987691f18aa85e5bf02d5df81 Gerrit-Change-Number: 17175 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 12 Mar 2021 17:48:18 +0000 Gerrit-HasComments: Yes
