Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17175 )
Change subject: [tool] Add the missing "member_type" in help text of list master CLI ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17175/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17175/1/src/kudu/tools/kudu-tool-test.cc@3347 PS1, Line 3347: > The point was that ASSERT_STR_CONTAINS("VOTER") matches in both "NON_VOTER" > and "VOTER" cases Definitely missed this point. Added comment and updated code to match other roles as well. -- To view, visit http://gerrit.cloudera.org:8080/17175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00f349687866269987691f18aa85e5bf02d5df81 Gerrit-Change-Number: 17175 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 15 Mar 2021 20:53:46 +0000 Gerrit-HasComments: Yes
