Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17175 )
Change subject: [tool] Add the missing "member_type" in help text of list master CLI ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17175/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17175/1/src/kudu/tools/kudu-tool-test.cc@3347 PS1, Line 3347: VOTER > In what case would a single master configuration have a master that's not a The code is a separate matter -- this is a test. If an assertion is in the test, it's an independent check. The point was that ASSERT_STR_CONTAINS("VOTER") matches in both "NON_VOTER" and "VOTER" cases. If there is a simple way to make sure that's matches only the latter -- why not to enforce it. If it's really hard, I'm fine to leave this as is. -- To view, visit http://gerrit.cloudera.org:8080/17175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00f349687866269987691f18aa85e5bf02d5df81 Gerrit-Change-Number: 17175 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 12 Mar 2021 19:18:29 +0000 Gerrit-HasComments: Yes
